[coreboot-gerrit] New patch to review for coreboot: cc9688d amd/dinar: Handle empty HOOKBEFORE_DRAM_INIT

[Kyösti Mälkki]

Kyösti Mälkki ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5683

-gerrit

commit cc9688d806177bf75f67c189d246af0b72d5213b
Author: Kyösti Mälkki 
Date:   Tue May 6 14:10:04 2014 +0300

amd/dinar: Handle empty HOOKBEFORE_DRAM_INIT

Removed function only read ACPI MMIO base address from a couple of
    registers in IO space.

Change-Id: I25a31b7ac1706b9eebc5db0b9604039928328b0a
    Signed-off-by: Kyösti Mälkki 
---
 src/mainboard/amd/dinar/BiosCallOuts.c | 30 +-----------------------------
 1 file changed, 1 insertion(+), 29 deletions(-)

diff --git a/src/mainboard/amd/dinar/BiosCallOuts.c b/src/mainboard/amd/dinar/BiosCallOuts.c
index b869e3b..e9715ba 100644
--- a/src/mainboard/amd/dinar/BiosCallOuts.c
+++ b/src/mainboard/amd/dinar/BiosCallOuts.c
@@ -97,7 +97,7 @@ STATIC BIOS_CALLOUT_STRUCT BiosCallouts[] =
    {AGESA_RUNFUNC_ONAP,			agesa_RunFuncOnAp },
    {AGESA_GNB_PCIE_SLOT_RESET,		agesa_NoopSuccess },
    {AGESA_GET_IDS_INIT_DATA,		agesa_EmptyIdsInitData },
-	{AGESA_HOOKBEFORE_DRAM_INIT,		BiosHookBeforeDramInit },
+	{AGESA_HOOKBEFORE_DRAM_INIT,		agesa_NoopSuccess },
    {AGESA_HOOKBEFORE_DRAM_INIT_RECOVERY,	agesa_NoopSuccess },
    {AGESA_HOOKBEFORE_DQS_TRAINING,		agesa_NoopSuccess },
    {AGESA_HOOKBEFORE_EXIT_SELF_REF,	agesa_NoopSuccess },
@@ -146,31 +146,3 @@ AGESA_STATUS BiosReadSpd (UINT32 Func, UINT32 Data, VOID *ConfigPtr)

return Status;
 }
-
-/*  Call the host environment interface to provide a user hook opportunity. */
-AGESA_STATUS BiosHookBeforeDramInit (UINT32 Func, UINT32 Data, VOID *ConfigPtr)
-{
-	AGESA_STATUS      Status;
-	UINTN             FcnData;
-	MEM_DATA_STRUCT   *MemData;
-	UINT32            AcpiMmioAddr;
-	UINT32            GpioMmioAddr;
-	UINT8             Data8;
-	UINT16            Data16;
-
-	FcnData = Data;
-	MemData = ConfigPtr;
-
-	Status  = AGESA_SUCCESS;
-	/* Get SB MMIO Base (AcpiMmioAddr) */
-	WriteIo8 (0xCD6, 0x27);
-	Data8   = ReadIo8(0xCD7);
-	Data16  = Data8<<8;
-	WriteIo8 (0xCD6, 0x26);
-	Data8   = ReadIo8(0xCD7);
-	Data16  |= Data8;
-	AcpiMmioAddr = (UINT32)Data16 << 16;
-	GpioMmioAddr = AcpiMmioAddr + GPIO_BASE;
-	Status = AGESA_SUCCESS;
-	return Status;
-}