[coreboot-gerrit] Change in coreboot[master]: mb/kontron/986lcd-m: Use `winbond_enable_serial()`

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39125 )

Change subject: mb/kontron/986lcd-m: Use `winbond_enable_serial()`
......................................................................

mb/kontron/986lcd-m: Use `winbond_enable_serial()`

Note, the common function does not set the IRQ.

pnp_set_irq(dev, PNP_IDX_IRQ0, 4);

Change-Id: Ia437aa31ae92a299d0d0b35db15715997ee9bad3
Signed-off-by: Paul Menzel 
---
M src/mainboard/kontron/986lcd-m/early_init.c
1 file changed, 6 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/39125/1

diff --git a/src/mainboard/kontron/986lcd-m/early_init.c b/src/mainboard/kontron/986lcd-m/early_init.c
index 827f792..467d907 100644
--- a/src/mainboard/kontron/986lcd-m/early_init.c
+++ b/src/mainboard/kontron/986lcd-m/early_init.c
@@ -52,19 +52,15 @@
    pnp_write_config(dev, 0x29, 0x43); /* GPIO settings */
    pnp_write_config(dev, 0x2a, 0x40); /* GPIO settings */

+	pnp_exit_conf_state(dev);
+
    dev = PNP_DEV(0x2e, W83627THG_SP1);
-	pnp_set_logical_device(dev);
-	pnp_set_enable(dev, 0);
-	pnp_set_iobase(dev, PNP_IDX_IO0, 0x3f8);
-	pnp_set_irq(dev, PNP_IDX_IRQ0, 4);
-	pnp_set_enable(dev, 1);
+	winbond_enable_serial(dev, 0x3f8);

dev = PNP_DEV(0x2e, W83627THG_SP2);
-	pnp_set_logical_device(dev);
-	pnp_set_enable(dev, 0);
-	pnp_set_iobase(dev, PNP_IDX_IO0, 0x2f8);
-	pnp_set_irq(dev, PNP_IDX_IRQ0, 3);
-	pnp_set_enable(dev, 1);
+	winbond_enable_serial(dev, 0x2f8);
+
+	pnp_enter_conf_state(dev);

dev = PNP_DEV(0x2e, W83627THG_KBC);
    pnp_set_logical_device(dev);