Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37929 )
Change subject: mb/intel/tglrvp: Update tglrvp_up3 devicetree
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37929/1/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37929/1/src/mainboard/intel/tglrvp/...
PS1, Line 141: off
on
Done
https://review.coreboot.org/c/coreboot/+/37929/1/src/mainboard/intel/tglrvp/...
PS1, Line 142: on
off
Done
https://review.coreboot.org/c/coreboot/+/37929/3/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37929/3/src/mainboard/intel/tglrvp/...
PS3, Line 27: # Enable Pch iSCLK
: register "pch_isclk" = "1"
Ack
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37929
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd0d9efe0ab4e050d2160f7662e4dc40a002672f
Gerrit-Change-Number: 37929
Gerrit-PatchSet: 5
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Jan 2020 04:45:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-MessageType: comment