Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl
......................................................................
Patch Set 6:
Patch Set 6:
Okay. I have a real problem because i am porting a board which I can not put into the tree like this. So until this is unresolved, I can not push it into gerrit.
Then elaborate please. Will it be another variant? or rather start
a new series?
See commit message. Looks like Christian wants to add a port for a coffeelake Supermicro board named X11SCH. Since coffeelake+friends use different chipset code, compared to the existing skylake+friends boards, adding it as a variant is not really a good idea. And then, since coffeelake+friends use the same LGA1151 socket as skylake+friends, the current name is ambiguous.
@Christian while everyone bikesheds about namings around here, I would suggest adding the X11SCH in a folder called "x11sch", and worry about naming issues later on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id213e79d7bcb5b6630dd0354cfce542e30ec9573
Gerrit-Change-Number: 35622
Gerrit-PatchSet: 6
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 05 Oct 2019 19:49:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment