Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37833 )
Change subject: hatch: Fix FPMCU pwr/rst gpio handling for dratini/jinlon ......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/c/coreboot/+/37833/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37833/2//COMMIT_MSG@9 PS2, Line 9: https://review.coreboot.org/c/coreboot/+/37459
Please add the commit hash and commit message summary.
Done
https://review.coreboot.org/c/coreboot/+/37833/2//COMMIT_MSG@9 PS2, Line 9: move
moves
Done
https://review.coreboot.org/c/coreboot/+/37833/2//COMMIT_MSG@10 PS2, Line 10: lose to implement in
does not implement it for
Done
https://review.coreboot.org/c/coreboot/+/37833/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37833/3//COMMIT_MSG@9 PS3, Line 9: https://review.coreboot.org/c/coreboot/+/37459(
Put a space before the (.
Done
https://review.coreboot.org/c/coreboot/+/37833/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/gpio.c:
https://review.coreboot.org/c/coreboot/+/37833/2/src/mainboard/google/hatch/... PS2, Line 154: * default_sleep_gpio_table but also, turn off FPMCU.
Some fits on the line above.
Done
https://review.coreboot.org/c/coreboot/+/37833/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/gpio.c:
https://review.coreboot.org/c/coreboot/+/37833/3/src/mainboard/google/hatch/... PS3, Line 116: * See https://review.coreboot.org/c/coreboot/+/32111 .
Maybe the commit ID is better here.
Done