Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39018 )
Change subject: ec/google/chromeec: Introduce SKU_ID helpers ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39018/3/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/39018/3/src/ec/google/chromeec/ec_b... PS3, Line 48: google_chromeec_smbios_system_sku
The trouble is the weak symbol smbios_system_sku is general and not necessarily a Google thing. […]
Ack
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_s... File src/ec/google/chromeec/ec_skuid.c:
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_s... PS4, Line 34: google_chromeec_smbios_system_sku
I agree, it is simple. […]
Ack