Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41723 )
Change subject: mb/google/dedede: re-arrange SPD indexes to keep all variants the same. ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41723/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41723/1//COMMIT_MSG@9 PS1, Line 9: the spd indexes of all variants will : be the same and this is updated to newest schematic already. I don't think we need to do this. Variants are going to diverge from the reference designs at some point and so they don't really need to follow the same IDs.
https://review.coreboot.org/c/coreboot/+/41723/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41723/1/src/mainboard/google/dedede... PS1, Line 3: empty Why? Let's not use empty IDs. Also these IDs were already configured in hardware for the current build, right?