Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36087 )
Change subject: soc/intel/tigerlake: Do initial SoC commit till ramstage ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36087/12/src/soc/intel/tigerlake/me... File src/soc/intel/tigerlake/memmap.c:
https://review.coreboot.org/c/coreboot/+/36087/12/src/soc/intel/tigerlake/me... PS12, Line 187: /* Fill up memory layout information */ : void fill_soc_memmap_ebda(struct ebda_config *cfg) : { : size_t chipset_mem_size; : : cfg->tolum_base = calculate_dram_base(&chipset_mem_size); : cfg->reserved_mem_size = chipset_mem_size; : }
Please don't use this.
Done
https://review.coreboot.org/c/coreboot/+/36087/12/src/soc/intel/tigerlake/me... PS12, Line 195: : void cbmem_top_init(void) : { : /* Fill up EBDA area */ : fill_ebda_area(); : }
remove.
Done
https://review.coreboot.org/c/coreboot/+/36087/12/src/soc/intel/tigerlake/me... PS12, Line 229: void *cbmem_top(void)
rebase on master please.
Done