Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41816 )
Change subject: soc/amd/picasso: add psp_verstage
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41816/10/src/soc/amd/picasso/memlay...
File src/soc/amd/picasso/memlayout_psp_verstage.ld:
https://review.coreboot.org/c/coreboot/+/41816/10/src/soc/amd/picasso/memlay...
PS10, Line 55: VERSTAGE_START + VERSTAGE_SIZE
Don't you want VBOOT_WORK_START? Or if you don't really care where it's located you can just use `. […]
Sorry, I missed this comment until just now.
This actually gives the same value as VBOOT_WORK_START. I'll update it in a follow-on patch and merge that with this patch if I need to repush this.
60K = 0xF000
0xF000 + 0x15000 = 0x24000
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia58839caa5bfbae0408702ee8d02ef482f2861c4
Gerrit-Change-Number: 41816
Gerrit-PatchSet: 11
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jul 2020 15:31:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment