Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34948 )
Change subject: superio: nuvoton: add a driver for nct668xd ......................................................................
Patch Set 4: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/34948/4/src/superio/nuvoton/common/... File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/34948/4/src/superio/nuvoton/common/... PS4, Line 76: : : don't remove the support for the nct6791 here
https://review.coreboot.org/c/coreboot/+/34948/4/src/superio/nuvoton/common/... PS4, Line 90: tmp u8 tmp
https://review.coreboot.org/c/coreboot/+/34948/4/src/superio/nuvoton/nct668x... File src/superio/nuvoton/nct668xd/superio.c:
https://review.coreboot.org/c/coreboot/+/34948/4/src/superio/nuvoton/nct668x... PS4, Line 71: NULL you can pass another device_operations struct here that has DEVICE_NOOP for .enable_resources and will only affect the (virtual) LDNs where it gets passed as override. same for the other virtual LDNs on LDN 7 and 9