[coreboot-gerrit] Change in coreboot[master]: soc/amd/psp_verstage: Get vb2_context early

[Rob Barnes (Code Review)]

Attention is currently required from: Jason Glenesk, Marshall Dawson, Kangheui Won, Felix Held.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59017 )

Change subject: soc/amd/psp_verstage: Get vb2_context early
......................................................................

Patch Set 1:

(1 comment)

File src/soc/amd/common/psp_verstage/psp_verstage.c:

https://review.coreboot.org/c/coreboot/+/59017/comment/db2ceb00_d7adc325 
PS1, Line 224:
> IMO vbnv_init(ctx->nvdata) should be added here since reboot_into_recovery calls vb2api_fail and vbo […]

Turns out, vbnv_init(ctx->nvdata) fails here because the cmos isn't ready until after verstage_soc_early_init/map_fch_devices. This also means reboot_into_recovery will fail here too. So the below error logic only works if verstage_soc_early_init mostly succeeds and cmos is accessible. This CL does not fix the bug completely, but it doesn't make worse either.

If there's a fatal error and the cmos is not accessible, is there a viable recovery path?