23 Oct
2020
23 Oct
'20
11:57 p.m.
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46640 )
Change subject: vc/intel/FSP2_0/CPX-SP: update to ww34 release and add watermark option ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46640/2/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/46640/2/src/mainboard/ocp/deltalake... PS2, Line 80: UnusedUpdSpace0 If there is no VPD setting,would it be safer to do nothing? I would expect the FSP to do something sane if this isn't set.
--
To view, visit https://review.coreboot.org/c/coreboot/+/46640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57ad01f33b92bf61a6a2725dd1cdbbc99c02405d
Gerrit-Change-Number: 46640
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Oct 2020 23:57:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment