Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41849 )
Change subject: cpu/x86/mtrr: add helper for setting multiple MTRRs ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41849/1/src/cpu/x86/mtrr/earlymtrr.... File src/cpu/x86/mtrr/earlymtrr.c:
https://review.coreboot.org/c/coreboot/+/41849/1/src/cpu/x86/mtrr/earlymtrr.... PS1, Line 104: * min base bit set and maximum size bit set. */
I can change the comments, but this is lifted from existing code in postcar_loader.c.
https://review.coreboot.org/c/coreboot/+/41849/1/src/include/cpu/x86/mtrr.h File src/include/cpu/x86/mtrr.h:
https://review.coreboot.org/c/coreboot/+/41849/1/src/include/cpu/x86/mtrr.h@... PS1, Line 117: * a future solution, such as postcar_loader. */
Done
https://review.coreboot.org/c/coreboot/+/41849/1/src/include/cpu/x86/mtrr.h@... PS1, Line 121: int used_var_mtrrs;
Can these be made of type unsigned or size_t?
They could. I don't think it matters.
https://review.coreboot.org/c/coreboot/+/41849/1/src/include/cpu/x86/mtrr.h@... PS1, Line 127: int
size_t/unsigned int
I don't think it matters.
https://review.coreboot.org/c/coreboot/+/41849/1/src/include/cpu/x86/mtrr.h@... PS1, Line 135: Returns < 0
Put that on the next line?
Done