Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41886 )
Change subject: dptf: Add support for Passive Policies
......................................................................
Patch Set 10: Code-Review+1
Should the passive policy need to check:
1) FAN is neither the target nor the source
2) CPU and may be charger are the only two devices being throttled
3) TSRs are the only devices that control the throttling.
Otherwise LGTM
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41886
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82e1c9022999b0a2a733aa6cd9c98a850e6f5408
Gerrit-Change-Number: 41886
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 19 Jun 2020 23:33:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment