[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Use SPI settings from EFS

[Matt Papageorge (Code Review)]

Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43303 )

Change subject: soc/amd/common: Use SPI settings from EFS
......................................................................

Patch Set 4:

(1 comment)

Looks like SPI settings have recently been refactored to be platform specific instead of the one in baseboard devicetree. Martin also has a patch up right now for moving spi speed configuration earlier.

So I will need to rebase this change. But before then we need to decide how to use to harvested the EFS speeds (if at all). Any ideas are welcome

https://review.coreboot.org/c/coreboot/+/43303/4/src/soc/amd/common/block/sp... 
File src/soc/amd/common/block/spi/fch_spi.c:

https://review.coreboot.org/c/coreboot/+/43303/4/src/soc/amd/common/block/sp... 
PS4, Line 92: 			   *spi_speed, *spi_speed);
> The specific SPI chip we use on Trembyle: […]

So should we move to just configuring the SPI Fast speed from EFS and leave everything else the same? Seems like that is the best of both worlds, but much more complex.