Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36045 )
Change subject: mb/g/drallion: Enable privacy screen on Drallion variant ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36045/7/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36045/7/src/mainboard/google/dralli... PS7, Line 229: 0x0400 I actually think that the _ADR shoud be 0x80000400. Looked at the ACPI spec pointed at by Duncan, https://uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf pages 1119 - 1123. We need the bit 31 set ("Device ID Scheme" bit)