29 Oct
2019
29 Oct
'19
9:40 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35497 )
Change subject: sc7180: Add gpio driver ......................................................................
Patch Set 11: Code-Review+2
(1 comment)
LGTM after one small fix
https://review.coreboot.org/c/coreboot/+/35497/11/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/35497/11/src/soc/qualcomm/sc7180/in... PS11, Line 95: #define GPIO_ENABLE 1 Let's please call these GPIO_OUTPUT_DISABLE and GPIO_OUTPUT_ENABLE, otherwise it looks confusing in the code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35497
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12bdbeb97765b6ae1e015ca35108008bf82801cc
Gerrit-Change-Number: 35497
Gerrit-PatchSet: 11
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Oct 2019 21:40:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment