Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30872 )
Change subject: [WIP] arch/x86: Add symbols for CAR MTRRs in linker script
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30872/5/src/arch/x86/car.ld
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/30872/5/src/arch/x86/car.ld@92
PS5, Line 92: /* Use CACHE_ROM_SIZE instead ? */
Yes! People already use >=32MiB chips that outgrew the ROM mapping.
And CONFIG_ROM_SIZE isn't necessarily a power of 2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef3546d2bfea2d4d8f87aaf8376e5566fd6aaa
Gerrit-Change-Number: 30872
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 May 2020 10:48:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment