build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48426 )
Change subject: asus/a88xm-e: add the PIRQ routing table ......................................................................
Patch Set 2:
(22 comments)
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... File src/mainboard/asus/a88xm-e/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 21: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 23: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 26: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 28: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 30: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 32: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 34: {0x00, (0x06 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 36: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 38: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 41: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 44: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 47: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 50: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 52: {0x00, (0x14 << 3) | 0x4, {{0x05, 0xccf0}, {0x06, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 54: {0x00, (0x15 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 56: {0x00, (0x15 << 3) | 0x1, {{0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 58: {0x00, (0x15 << 3) | 0x2, {{0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 60: {0x00, (0x15 << 3) | 0x3, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 62: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x1, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 64: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x2, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 66: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x3, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 68: {0x04, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x4, 0x0} line over 96 characters