Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33934 )
Change subject: lib: Rewrite qemu-armv7 ramdetect
......................................................................
Patch Set 3:
Patch Set 3:
Just wondering, doesn't qemu-armv7 have the same `fw_cfg` interface
as the x86 ones? Then we could just use the reported memory regions?
yes, on armv7 it exists and is memory mapped. However on other architectures it does not exist.
I like to use this code as fallback. Other methods like MMIO fw_cfg and FDT should be preferred, but right now they aren't implemented.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37386c6a95bfc3b7b25aeae32c6e14cff9913513
Gerrit-Change-Number: 33934
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 07 Jul 2019 14:41:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment