Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35944 )
Change subject: mb/google/hatch: Add new touchscreen option for Kohaku
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35944/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35944/1/src/mainboard/google/hatch/...
PS1, Line 189: ACPI_IRQ_EDGE_LOW
Does this have a different trigger than atmel?
Yes. Some Octopus devices used this same touchscreen, and they are using edge-triggered.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35944
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I135e693304cbb8dffc0caf4c07846033d6802208
Gerrit-Change-Number: 35944
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Oct 2019 14:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment