Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33033 )
Change subject: superio/common: Add ssdtgen for generic SuperIOs ......................................................................
Patch Set 21:
(3 comments)
I'll drop my devicetree entry structure related concerns for now; would be good to have some sort of comment on that line in the documentation. The .0 in the devicetree entry for the SIO chip itself and not its LDNs doesn't make sense, but is probably a current limitation of the devcetree format. Would be worth a thought if it would be useful to add a pnp device format to the devicetree without the .LDN for devices with no LDNs that could also be used for the TPM or IPMI devices.
https://review.coreboot.org/c/coreboot/+/33033/21/Documentation/superio/comm... File Documentation/superio/common/ssdt.md:
https://review.coreboot.org/c/coreboot/+/33033/21/Documentation/superio/comm... PS21, Line 24: device pnp 2e.0 on maybe add a "just for the base device, not for the LDNs" here as a comment
https://review.coreboot.org/c/coreboot/+/33033/19/src/superio/common/generic... File src/superio/common/generic.c:
https://review.coreboot.org/c/coreboot/+/33033/19/src/superio/common/generic... PS19, Line 29: res->flags |= IORESOURCE_STORED;
ok
Done
https://review.coreboot.org/c/coreboot/+/33033/19/src/superio/common/generic... PS19, Line 167: * coreboot's generic allocator doesn't expect them behind PnP devices.
ok, that makes sense
Done