I'll drop my devicetree entry structure related concerns for now; would be good to have some sort of comment on that line in the documentation. The .0 in the devicetree entry for the SIO chip itself and not its LDNs doesn't make sense, but is probably a current limitation of the devcetree format.
Would be worth a thought if it would be useful to add a pnp device format to the devicetree without the .LDN for devices with no LDNs that could also be used for the TPM or IPMI devices.

View Change

3 comments:

• File Documentation/superio/common/ssdt.md:

  • Patch Set #21, Line 24: device pnp 2e.0 on

    maybe add a "just for the base device, not for the LDNs" here as a comment

• File src/superio/common/generic.c:

  • Patch Set #19, Line 29: res->flags |= IORESOURCE_STORED;

    ok

    Done

  • Patch Set #19, Line 167: * coreboot's generic allocator doesn't expect them behind PnP devices.

    ok, that makes sense

    Done

To view, visit change 33033. To unsubscribe, or for help writing mail filters, visit settings.