Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 5:
Patch Set 5:
Good catch!
Well, what about x11-lga1151v1-series? The inofficial name of LGA1151 for coffee lake is LGA1151v2, so we could have x11-lga1151v1-series and x11-lga1151v2-series
I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Ouch, yes... x11-lga1151-sklkbl-series :'D just kidding....
Ok... here some facts from supermicro:
X11 is available with multiple different sockets, soldered and socketed, multiple chipsets and multiple cpu generations, multi- and single socket.
Single socket is encoded as the first letter S as in X11S -> prefix could be x11s-
Chipsets available: C232/C236, C242/C246 CPU generations grouped by socket/pin compatibility: v5/v6 (skl/kbl), v7/v8 (cnl/cfl)
There Intel Processor W (Skylake SP) boards which all have the prefix X11SR or X11SP.
Most boards that are compatible with X11SSH and X11SSM have the prefix X11SS. Guess what? Yes, there are exceptions... of course: X11SAT, X11SAE.
I looked at many board names at the mainboard matrix (SM website) and it seems, that the second char after X11 reflects the CPU generation: X11SS could mean X11S-SkyKabylake, while X11SC (as in X11SCL and many other Coffelake boards) could be X11S-CannonCoffeelake. This is pure speculation but seems to fit in 99%.
option 1)We could use x11ss- as prefix (and ignore that maybe the two exceptions X11SAT and X11SAE get into this group some day); The full name would be x11ss-lga1151-series and x11sc-lga1151-series, then.
option 2) keep x11s- as prefix. Then we have to separate v5/v6 (skl/kbl), v7/v8 (cnl/cfl) by another tag. Examples: x11s-v5v6- and x11s-v7v8- or x11s-sklkbl- and x11s-cnlcfl- Then we have 29 Boards with Socket 1151v1, and some with some FCBGA-*.