[coreboot-gerrit] [L] Change in coreboot[master]: soc/intel/jasperlake: Add per-SKU power limits

[Reka Norman (Code Review)]

Attention is currently required from: ChiaLing, Paul Menzel, Ryan Lin, Subrata Banik, Sumeet R Pawnikar, Zhuohao Lee.

Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75679?usp=email )

Change subject: soc/intel/jasperlake: Add per-SKU power limits
......................................................................

Patch Set 7:

(1 comment)

File src/mainboard/google/dedede/variants/blipper/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/75679/comment/0c5fb02c_f333492a :
PS5, Line 62: 	register "power_limits_config" = "{
            : 			.tdp_pl1_override = 6,
            : 			.tdp_pl2_override = 20,
            : 	}"
> Hi Reka, […]

I just want to make sure we're not changing the settings on existing dedede devices. Currently the baseboard doesn't set PL4, but with your change it will, so this affects all devices.

If I understand correctly, 60W is the default, so if coreboot doesn't set PL4 it will be set to 60W. Is that right? I just checked a random dedede device and that seems to be the case.

If so then I guess technically this would be fine, but I still think it's safer to keep the coreboot behaviour the same for exising devices, i.e. coreboot shouldn't set PL4.

How about in the baseboard devicetree we don't set PL4, and dibbi variants can override it?