Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42035 )
Change subject: google/kukui: Add ddr geometry to support 6GB, 8GB DDR bootup
......................................................................
Patch Set 5:
Patch Set 5:
Does the parent commit still work without this change? If not, they should be squashed.
I just had the same question. Since DDR_TYPE_2CH_2RK_4GB_2_2 is the default value (= 0), the parent CL should work fine without this one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b53ab2bf43e0dfb7448eb37a18faf686267eaed
Gerrit-Change-Number: 42035
Gerrit-PatchSet: 5
Gerrit-Owner: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Wed, 03 Jun 2020 15:32:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment