Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37643 )
Change subject: Documentation: Add proposal for firmware testing ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... File Documentation/technotes/2019-12-firmware-testing.md:
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 9: Lava
This lava? https://minecraft.gamepedia. […]
no, added the link.
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 20: test host
Would be nice if the test host could be in control of more than one DUT. […]
Ack on driving multiple DUTs (added). As for network, I consider that outside the scope of the test runner itself. I think that relying on network for test communication only adds complexity (which side failed configuring its network _this_ time?). The idea is to tailor this around the barest minimum of components and, incidentally, cut down on log sizes as well (the logs we get from Chromium OS' test infra are gigantic, and I can't claim that this improves anything).
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 32: It may also be augmented by additional circuitry that : allows automating these steps.
That's exactly the only thing I've done of my automated test setup. […]
so my plan will be to provide (compile-time) pluggable modules for that, and driving two kinds myself: the manual operator UI (on some random DUT I have here) and integration with Chrome OS' servo tools.
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 39: So these are
Seems like something went missing here?
"So these are ... Requirement 1 ... and ... Requirement 2", maybe I got overboard with being fancy here? ;-)
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 45: and
?
see above.
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 106: The language should be popular and the implementation robust.
Required already below?
I styled the doc in having prose explaining the properties and with requirements extracted from them interspersed. You're right that the direct repetition isn't helpful though. Hmm...
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 147: set up
set-up/setup?
Done