Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )
Change subject: mediatek/mt8183: Init SPM driver ......................................................................
Patch Set 26:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34545/17/src/mainboard/google/kukui... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34545/17/src/mainboard/google/kukui... PS17, Line 161: SPM initial fail!!!
ok, would change it on next version.
Done
https://review.coreboot.org/c/coreboot/+/34545/17/src/soc/mediatek/mt8183/Ma... File src/soc/mediatek/mt8183/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34545/17/src/soc/mediatek/mt8183/Ma... PS17, Line 72: 3rdparty/blobs/soc/mediatek/mt8183/pcm_allinone_lp4_3200.bin
ok, would change it on next version.
Done
https://review.coreboot.org/c/coreboot/+/34545/17/src/soc/mediatek/mt8183/sp... File src/soc/mediatek/mt8183/spm.c:
https://review.coreboot.org/c/coreboot/+/34545/17/src/soc/mediatek/mt8183/sp... PS17, Line 80: write32(&mtk_spm->spare_ack_mask, : (read32(&mtk_spm->spare_ack_mask) & ~SPARE_ACK_MASK_B_BIT1) | : SPARE_ACK_MASK_B_BIT0);
Yes, would change it on next version.
Done
https://review.coreboot.org/c/coreboot/+/34545/17/src/soc/mediatek/mt8183/sp... PS17, Line 88: write32
Yes, would change it on next version.
Done
https://review.coreboot.org/c/coreboot/+/34545/17/src/soc/mediatek/mt8183/sp... PS17, Line 130: read32(&mtk_spm->pcm_reg0_data)
ok, would change it on next version.
Done
https://review.coreboot.org/c/coreboot/+/34545/17/src/soc/mediatek/mt8183/sp... PS17, Line 135: write32
ok, would change it on next version.
Done