Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/22584
to review the following change.
Change subject: mb/google/poppy/variants/nautilus: remove ALS and correct PS2K typo. ......................................................................
mb/google/poppy/variants/nautilus: remove ALS and correct PS2K typo.
1.nautilus doesn't support als. remove the definition from ec.h.
2.correct the SIO_EC_ENABLE_P2SK to SIO_EC_ENABLE_PS2K.
BRANCH=master BUG=none TEST=compiled/boot to ChromeOS.
Change-Id: Ib357328799015f78b18cd260db221e524e98cef7 Signed-off-by: Chris Wang chriswang@ami.corp-partner.google.com --- M src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h 1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/22584/1
diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h index 7bee05a..ca9f865 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h @@ -65,9 +65,6 @@ * ACPI related definitions for ASL code. */
-/* Enable EC backed ALS device in ACPI */ -#define EC_ENABLE_ALS_DEVICE - /* Enable EC backed PD MCU device in ACPI */ #define EC_ENABLE_PD_MCU_DEVICE
@@ -78,6 +75,6 @@
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ -#define SIO_EC_ENABLE_P2SK +#define SIO_EC_ENABLE_PS2K
#endif /* __MAINBOARD_EC_H__ */