Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44897 )
Change subject: Revert "soc/amd/acpi: Move ACPI IVRS generation to coreboot"
......................................................................
Patch Set 4:
I was able to reproduce locally over the weekend. I had added an entry for a second IOAPIC on the IOHC, based on the PPRs, but there is not a second device in the MADT. It is looking like that is what is leading to the hang. When i remove the second entry, i'm able to fully boot without amd_iommu=off kernel param. I have a few more experiments to run today, but would like to submit a follow up patch to remove the second IVRS entry. I need to firm up some things from the PPR as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44897
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idee1c7e829282427ee80f7d7071793b000936810
Gerrit-Change-Number: 44897
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 31 Aug 2020 15:27:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment