16 Jul
2021
16 Jul
'21
5 a.m.
Attention is currently required from: Dtrain Hsu, Ian Feng, Henry Sun, Paul Menzel, Shou-Chieh Hsu. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56248 )
Change subject: mb/google/dedede/var/cret: Enable/disable Touchscreen based on FW_CONFIG ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4: LGTM except for the Nit.
File src/mainboard/google/dedede/variants/cret/gpio.c:
https://review.coreboot.org/c/coreboot/+/56248/comment/230e77c4_36f2267b PS4, Line 103: / Nit: Move this comment after line 105
--
To view, visit https://review.coreboot.org/c/coreboot/+/56248
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice517c034e2dab93bb27e75dccf06d9a0936526b
Gerrit-Change-Number: 56248
Gerrit-PatchSet: 4
Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com
Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Henry Sun henrysun@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Comment-Date: Fri, 16 Jul 2021 05:00:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment