Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39359 )
Change subject: soc/intel/tigerlake: Save DIMM info by available nodes
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39359/1/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/39359/1/src/soc/intel/tigerlake/rom...
PS1, Line 75: MAX_NODE
Where is this defined?
MAX_NODE is defined @ src/vendorcode/intel/fsp/fsp2_0/tigerlake/MemInfoHob.h
#define MAX_NODE 2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I951ea94c280b7dd5b67f320a264d13fca82a4596
Gerrit-Change-Number: 39359
Gerrit-PatchSet: 1
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Mon, 09 Mar 2020 20:23:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment