Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45759 )
Change subject: soc/intel/alderlake/ramstage: Do initial SoC commit till ramstage ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45759/1/src/soc/intel/alderlake/fsp... File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45759/1/src/soc/intel/alderlake/fsp... PS1, Line 157: if (config->usb3_ports[i].enable) {
braces {} are not necessary for any arm of this statement
Done
https://review.coreboot.org/c/coreboot/+/45759/1/src/soc/intel/alderlake/sou... File src/soc/intel/alderlake/soundwire.c:
https://review.coreboot.org/c/coreboot/+/45759/1/src/soc/intel/alderlake/sou... PS1, Line 39: /* TODO: Verified Audio in nocodec mode, add codec suppport */
'suppport' may be misspelled - perhaps 'support'?
Done