build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40701 )
Change subject: device: Constify struct device * parameter to write_acpi_tables
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40701/4/src/soc/intel/skylake/inclu...
File src/soc/intel/skylake/include/soc/acpi.h:
https://review.coreboot.org/c/coreboot/+/40701/4/src/soc/intel/skylake/inclu...
PS4, Line 22: unsigned long northbridge_write_acpi_tables(const struct device *,
function definition argument 'const struct device *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40701/4/src/soc/intel/skylake/inclu...
PS4, Line 22: unsigned long northbridge_write_acpi_tables(const struct device *,
function definition argument 'struct acpi_rsdp *' should also have an identifier name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40701
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50d013e83a404e0a0e3837ca16fa75c7eaa0e14a
Gerrit-Change-Number: 40701
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Apr 2020 18:58:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment