Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33623 )
Change subject: superio/fintek: Add f81803a ......................................................................
Patch Set 6:
Patch Set 6: Code-Review+1
looks good to me. I'll wait with +2ing and merging until there's a patch using the SIO support added in this patch. Without a board using a SIO, the SIO code doesn't get build tested. Poke me again when the board code is on Gerrit and buildbot is happy with that patch and I'll get this patch merged.
Oh and I have to say that I prefer the current state of the fan control API added in this patch over the devicetree-based one used by other SIO/EC :)
I could have created something devicetree based, but the structure would have to be too complicated due to all the parameters that needs to be controlled. I thought that an API breaking the parameters into logically grouped parameters was much easier to understand and program.
As I mentioned before, I can't merge Padmelon board until 33615 is merged. Locally, I have build and tested the SIO code... found 1 mistake (caused by trying to enable HWM too early of all things, lol). Once I moved enabling HWM to early ramstage (just before calling the API), it worked as expected.