[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Steal no memory for disabled IGD

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39454 )

Change subject: soc/intel/cannonlake: Steal no memory for disabled IGD
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39454/13/src/soc/intel/cannonlake/r... 
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/39454/13/src/soc/intel/cannonlake/r... 
PS13, Line 39: 	 * to prevent a crash in FSP-M.
> Please don't add comments about what you do. AIUI, it was asked for a comment, […]

Just another thought, it might be easier to read if we'd check the positive
case:

if (dev && dev->enabled && pci_read_config16(SA_DEV_IGD, PCI_VENDOR_ID) != 0xffff)