Attention is currently required from: Felix Singer, Iru Cai, Nicholas Chin.
Daniel Maslowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77534?usp=email )
Change subject: ec/dell/mec5035: Add command to enable/disable radios
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Suggestion for a more human speak implementation:
```
// turn the readio on
void mec5035_radio_on(enum mec5035_radio_dev dev)
{
/* From LPC traces and userspace testing with other values,
the second byte has to be 2 for an unknown reason. */
u8 buf[3] = {dev, 2, RADIO_ON};
write_mailbox_regs(buf, 2, 3);
ec_command(CMD_SET_RADIO);
}
// turn the readio off
void mec5035_radio_off(enum mec5035_radio_dev dev)
{
/* From LPC traces and userspace testing with other values,
the second byte has to be 2 for an unknown reason. */
u8 buf[3] = {dev, 2, RADIO_OFF};
write_mailbox_regs(buf, 2, 3);
ec_command(CMD_SET_RADIO);
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77534?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I173dc197d63cda232dd7ede0cb798ab0a364482b
Gerrit-Change-Number: 77534
Gerrit-PatchSet: 6
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Maslowski
info@orangecms.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Comment-Date: Mon, 16 Oct 2023 10:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment