[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp1.1: Use the coreboot symbols for the stack

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37276 )

Change subject: drivers/intel/fsp1.1: Use the coreboot symbols for the stack
......................................................................

Patch Set 2:

(2 comments)

Commit message need

https://review.coreboot.org/c/coreboot/+/37276/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37276/2//COMMIT_MSG@10 
PS2, Line 10: override other CAR symbols.
This should say more clearly commit actually moves the stack inside CAR.

https://review.coreboot.org/c/coreboot/+/37276/2/src/drivers/intel/fsp1_1/ca... 
File src/drivers/intel/fsp1_1/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/37276/2/src/drivers/intel/fsp1_1/ca... 
PS2, Line 138: 	 * edx:  Temp RAM top
I don't see how where these ecx and edx are tied to DCACHE_RAM_BASE and _SIZE, while the symbol _ecar_stack below is.