Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31253 )
Change subject: riscv: Add initial support for 32bit boards
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31253/3/src/lib/libgcc.c
File src/lib/libgcc.c:
https://review.coreboot.org/#/c/31253/3/src/lib/libgcc.c@24
PS3, Line 24: #if !IS_ENABLED(CONFIG_ARCH_X86) && !IS_ENABLED(CONFIG_ARCH_RISCV_RV32)
Analyze why this is needed on RV32
https://review.coreboot.org/#/c/31253/3/src/soc/ucb/riscv/Kconfig
File src/soc/ucb/riscv/Kconfig:
https://review.coreboot.org/#/c/31253/3/src/soc/ucb/riscv/Kconfig@37
PS3, Line 37: default "rv32im"
is this correct?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31253
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35e59b459d1770df10b51fe9e77dcc474d7c75a0
Gerrit-Change-Number: 31253
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 11 Feb 2019 23:50:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment