Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34890 )
Change subject: util/superiotool: default to using the first discovered chip and exit (let's fix false positives so this isn't necessary); put aspeed in the appropriate execution order to prevent false positives. ......................................................................
Patch Set 1:
(1 comment)
I agree with Felix: while multiple SIOs on a board is rare, it can happen. And breaking superiotool on those cases doesn't sound alright.
Maybe make it like flashrom, that has a commandline switch to specify the flash chip definition to use? Though for superiotool, maybe a simpler "vendor mask" would do: if you know your board only has ITE and Nuvoton chips, just probe for those vendors.
https://review.coreboot.org/c/coreboot/+/34890/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34890/1//COMMIT_MSG@7 PS1, Line 7: util/superiotool: default to using the first discovered chip and exit (let's fix false positives so this isn't necessary); put aspeed in the appropriate execution order to prevent false positives. I think this line miiight be bit too long for a commit summary