Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44632 )
Change subject: mb/google/volteer/variants/eldrid: add memory.c for ddr4 support
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44632/16/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44632/16/src/mainboard/google/volte...
PS16, Line 68: register "generic.hid" = ""GDIX0000""
: register "generic.desc" = ""Goodix Touchscreen""
: register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)"
: register "generic.probed" = "1"
: register "generic.reset_gpio" =
: "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)"
: register "generic.reset_delay_ms" = "120"
: register "generic.reset_off_delay_ms" = "3"
: register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)"
: register "generic.enable_delay_ms" = "12"
: register "generic.has_power_resource" = "1"
: register "hid_desc_reg_offset" = "0x01"
: device i2c 14 on end
please compare this with volteer/variants/volteer2/overridetree.cb
we have updated the timings to correct timing violations.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44632
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c7b30093a8d85bac5aba5b83768af5eb36c4f70
Gerrit-Change-Number: 44632
Gerrit-PatchSet: 16
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Assignee: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Mice Lin
mice_lin@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Thu, 03 Sep 2020 09:41:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment