[coreboot-gerrit] Change in ...coreboot[master]: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake
......................................................................

Patch Set 5:

(2 comments)

Looks good, but there's two things that look odd to me.

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... 
File src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h:

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... 
PS5, Line 2298: 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
This change is not listed in the commit message

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... 
File src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h:

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... 
PS5, Line 853: Chickent
Chicken