Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43760 )
Change subject: mb/clevo/kbl-u: Add Clevo N240BU as variant ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... File src/mainboard/clevo/kbl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... PS14, Line 3: if BOARD_CLEVO_N13xWU || BOARD_CLEVO_N240BU let's go for a baseboard approch, because this will get way too long. see x11-lga1151-series
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... PS14, Line 54: default 8 if BOARD_CLEVO_N13xWU || BOARD_CLEVO_N240BU we need a different solution here, this list will get veeeeeeeeery looooong
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... File src/mainboard/clevo/kbl-u/variants/n240bu/include/gpio_table.h:
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... PS14, Line 2: use maxim's intelp2m tool to convert this and verify it with schematics, please. example: https://review.coreboot.org/c/coreboot/+/43652/19..20/src/mainboard/system76...