Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46971 )
Change subject: soc/intel/xeon_sp; Use soc specific stack-port function
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46971/1/src/soc/intel/xeon_sp/skx/s...
File src/soc/intel/xeon_sp/skx/soc_util.c:
https://review.coreboot.org/c/coreboot/+/46971/1/src/soc/intel/xeon_sp/skx/s...
PS1, Line 415:
: else if (port >= PORT_4A && port <= PORT_4D)
: return PSTACK3; // MCP0
: else if (port >= PORT_5A && port <= PORT_5D)
: return PSTACK4; // MCP1
I know this is a refactor, but it would be good to document these.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46971
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib38a7d66947ded9b56193a9163e5128b2523e99c
Gerrit-Change-Number: 46971
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 31 Oct 2020 21:54:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment