Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48264 )
Change subject: mb/google/volteer/var/voxel: Update DPTF parameters
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48264/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/voxel/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48264/1/src/mainboard/google/voltee...
PS1, Line 4: register "tcc_offset" = "10" # TCC of 90
You can remove it. It is the same setting as baseboard. […]
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48264
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaac1fae12ccaa8a623bc2dc3105262918523d440
Gerrit-Change-Number: 48264
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 07 Dec 2020 03:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-MessageType: comment