[coreboot-gerrit] Change in coreboot[master]: arch/x86: Top align bootblock program

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37895 )

Change subject: arch/x86: Top align bootblock program
......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/37895/4/src/cpu/x86/16bit/reset16.l... 
File src/cpu/x86/16bit/reset16.ld:

https://review.coreboot.org/c/coreboot/+/37895/4/src/cpu/x86/16bit/reset16.l... 
PS4, Line 28: 	INCLUDE "bootblock/lib/program.ld"
Have you given much thought into ensuring a minimum alignment for just the pieces (presumably bootblock.top along w/ reset vector)? And then also ensuring the bss/data comes prior or after depending on option?

https://review.coreboot.org/c/coreboot/+/37895/4/src/cpu/x86/16bit/reset16.l... 
PS4, Line 30: 	.bootblock_top . : {
This sequence will punch a hole between bss/heap and 2 text segments.

https://review.coreboot.org/c/coreboot/+/37895/4/src/cpu/x86/16bit/reset16.l... 
PS4, Line 46: 0xf0
Why the 256 (0xf0 + 16) total offset subtracted from the calculation? I'm not following all the math as to the reasoning.