[coreboot-gerrit] Change in coreboot[master]: drivers/gfx: Add generic graphics with SSDT generator

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36041 )

Change subject: drivers/gfx: Add generic graphics with SSDT generator
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36041/10/src/drivers/generic/gfx/gf... 
File src/drivers/generic/gfx/gfx.c:

https://review.coreboot.org/c/coreboot/+/36041/10/src/drivers/generic/gfx/gf... 
PS10, Line 26: C7033113-8720-4CEB-9090-9D52B3E52D73
Since we're proposing a new interface for both BIOS and Kernel to use we might want to publish a design in docs/ for how the BIOS<>Kernel interaction is expected to work.

https://review.coreboot.org/c/coreboot/+/36041/10/src/drivers/generic/gfx/gf... 
PS10, Line 104: GFX0
It might be useful to have a devicetree config item to set this (with GFX0 being default if nothing is set) in case an SOC does not use GFX0 for the device name.