Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50510 )
Change subject: soc/amd/cezanne: Fill FADT and MADT ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50510/comment/bd904c08_0c66afc9 PS1, Line 9: configure nit: move to next line
File src/soc/amd/cezanne/acpi.c:
https://review.coreboot.org/c/coreboot/+/50510/comment/9aa91342_05916067 PS1, Line 85: fadt->res2 = 0; /* reserved, MUST be 0 ACPI 3.0 */ IIRC the FADT is already zero-initialized.
https://review.coreboot.org/c/coreboot/+/50510/comment/acebeef0_5a93057a PS1, Line 100: fadt->x_firmware_ctl_h = 0; src/acpi/acpi.c sets `x_firmware_ctl_l`, and this code overwrites the value. Is this SoC-specific, or is it to comply with the ACPI spec?
File src/soc/amd/cezanne/include/soc/acpi.h:
https://review.coreboot.org/c/coreboot/+/50510/comment/1a72adf6_39848a05 PS1, Line 9: 0x0D nit: lowercase hex