Attention is currently required from: Raul Rangel, Mathew King, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51047 )
Change subject: mb/google/guybrush: Add eSPI configuration
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/51047/comment/1f11b715_9fd99f33
PS3, Line 7: .generic_io_range[0] = {
: .base = 0x62,
: /*
: * Only 0x62 and 0x66 are required. But, this is not supported by
: * standard IO decodes and there are only 4 generic I/O windows
: * available. Hence, open a window from 0x62-0x67.
: */
: .size = 5,
: },
Are we supporting ps/2 touchpoint?
We should be able to support PS/2 mouse, but this is needed for the keyboard and EC communication as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51047
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic607d6bca5c70255332a6fbee2b63e6daba7d1e7
Gerrit-Change-Number: 51047
Gerrit-PatchSet: 10
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 Mar 2021 17:04:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment