[coreboot-gerrit] Change in coreboot[master]: drivers/vpd: set bool type variable matching with key/value pair

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34634 )

Change subject: drivers/vpd: set bool type variable matching with key/value pair
......................................................................

Patch Set 2: Code-Review-1

(2 comments)

https://review.coreboot.org/c/coreboot/+/34634/2/src/drivers/vpd/vpd_fsp.c 
File src/drivers/vpd/vpd_fsp.c:

https://review.coreboot.org/c/coreboot/+/34634/2/src/drivers/vpd/vpd_fsp.c@2... 
PS2, Line 26:  || value_len != 1
Why does value_len need to be passed in at all? It's not used elsewhere in this function. A check that value != NULL should be sufficient.

https://review.coreboot.org/c/coreboot/+/34634/2/src/drivers/vpd/vpd_fsp.c@4... 
PS2, Line 42: else
            : 		return false;
            : }
There's some controversy in the community about braces, but the current style guide dictates (basically the same as Linux) dictates that you should use braces in cases where there is more than one action per branch (https://doc.coreboot.org/coding_style.html?highlight=coding#placing-braces-a...).